1. emailfortesting000001@gmail.com
  2. Feature ideas for WP File Download
  3. Friday, 18 October 2019
  4.  Subscribe via email
I am a web developer and I use WP File Download plugin.
Unfortunately, I found a critical issue in the plugin code.
Please check the following file:line
wp-file-download/framework/ju-libraries/WPFramework/v1_0_5/Model.php:51

There you can see 'elseif' condition that will always be true.

} elseif ($type !== 'admin' || $type !== 'site') {
return false;
}

In my opinion, there should be 'AND' condition, not 'OR':

} elseif ($type !== 'admin' && $type !== 'site') {
return false;
}

Please fix this ASAP, because it is impossible to work with the model instances outside the plugin.
Thank you
Responses (1)
Accepted Answer Pending Moderation
Hi,

Thanks for your feedback.

Please check the following file:line
wp-file-download/framework/ju-libraries/WPFramework/v1_0_5/Model.php:51

There you can see 'elseif' condition that will always be true.

} elseif ($type !== 'admin' || $type !== 'site') {
return false;
}

In my opinion, there should be 'AND' condition, not 'OR':

} elseif ($type !== 'admin' && $type !== 'site') {
return false;
}

Please fix this ASAP, because it is impossible to work with the model instances outside the plugin.


Our dev in charge will check and fix that soon in the near future.

Thanks a lot!
Cheers,
  • Page :
  • 1


There are no replies made for this post yet.
Be one of the first to reply to this post!