Skip to main content
  Friday, October 18 2019
  1 Replies
  1K Visits
  Subscribe
I am a web developer and I use WP File Download plugin.
Unfortunately, I found a critical issue in the plugin code.
Please check the following file:line
wp-file-download/framework/ju-libraries/WPFramework/v1_0_5/Model.php:51

There you can see 'elseif' condition that will always be true.

} elseif ($type !== 'admin' || $type !== 'site') {
return false;
}

In my opinion, there should be 'AND' condition, not 'OR':

} elseif ($type !== 'admin' && $type !== 'site') {
return false;
}

Please fix this ASAP, because it is impossible to work with the model instances outside the plugin.
Thank you
A
4 years ago
Hi,

Thanks for your feedback.

Please check the following file:line
wp-file-download/framework/ju-libraries/WPFramework/v1_0_5/Model.php:51

There you can see 'elseif' condition that will always be true.

} elseif ($type !== 'admin' || $type !== 'site') {
return false;
}

In my opinion, there should be 'AND' condition, not 'OR':

} elseif ($type !== 'admin' && $type !== 'site') {
return false;
}

Please fix this ASAP, because it is impossible to work with the model instances outside the plugin.


Our dev in charge will check and fix that soon in the near future.

Thanks a lot!
Cheers,
  • Page :
  • 1
There are no replies made for this post yet.